Skip to content

Conversation

@ZhanruiSunCh
Copy link
Collaborator

@ZhanruiSunCh ZhanruiSunCh commented Oct 8, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Ensured CUDA 13 compatibility on x86_64 by switching dependency to pytorch-triton 3.3.1 (replacing public triton).
  • Chores

    • Simplified Docker image build by removing post-install Triton adjustments, reducing build complexity and side effects.
  • Tests

    • Removed CUDA 13-specific Triton workaround from CI tests for Python 3.12 (DLFW), aligning tests with the new dependency setup.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@ZhanruiSunCh ZhanruiSunCh requested review from a team as code owners October 8, 2025 05:57
@ZhanruiSunCh ZhanruiSunCh force-pushed the user/zhanruis/1008_remove_triton_war_code branch from 51fed7d to 83d93f7 Compare October 8, 2025 05:57
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

📝 Walkthrough

Walkthrough

Removed Triton post-install/metadata manipulation from Dockerfile and Jenkins CI script. Switched dependency from triton to pytorch-triton for x86_64 in requirements. Overall, eliminates custom renaming/RECORD edits and CUDA 13 workaround, standardizing on pytorch-triton installation.

Changes

Cohort / File(s) Summary
Docker image build cleanup
docker/Dockerfile.multi
Deleted non-Red Hat conditional post-install block that rewrote Triton packaging (renaming pytorch_triton→triton, METADATA/RECORD edits, ldconfig/logging).
CI test pipeline simplification
jenkins/L0_Test.groovy
Removed CUDA 13 workaround for PY312-DLFW path that installed nightly Triton and rewrote package metadata/files.
Dependency switch for x86_64
requirements.txt
Commented out triton==3.3.1; platform_machine == "x86_64" and added pytorch-triton==3.3.1; platform_machine == "x86_64" with note about CUDA 13 support.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The current title implies that a script is being introduced to handle Triton WAR code, whereas the changes actually remove the WAR code entirely and simplify installation for CUDA 13 environments rather than adding or using a script. This mismatch between the title and the main changeset makes it misleading. Please revise the title to accurately summarize the primary change, for example: “[TRTLLM-8464][infra] remove Triton WAR code and simplify CUDA 13 installation.”
Description Check ⚠️ Warning The pull request description consists solely of the repository’s template placeholders and does not include a concrete title, summary of changes, or test coverage information. The required “Title” section is missing actual content, and both the “Description” and “Test Coverage” sections are empty. Without filling these sections, the PR description does not adhere to the repository’s description template. Please update the PR description by providing a valid title following the repository’s template, a concise description of the issue and changes implemented, and a clear list of relevant tests under “Test Coverage,” then ensure all checklist items are reviewed.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20769 [ run ] triggered by Bot

@ZhanruiSunCh ZhanruiSunCh force-pushed the user/zhanruis/1008_remove_triton_war_code branch from 83d93f7 to ec5b1a5 Compare October 8, 2025 08:02
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20776 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20769 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15697 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20776 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #15706 completed with status: 'FAILURE'

@ZhanruiSunCh
Copy link
Collaborator Author

/bot run

@ZhanruiSunCh ZhanruiSunCh force-pushed the user/zhanruis/1008_remove_triton_war_code branch from 21f69f9 to d960dc9 Compare October 9, 2025 03:59
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20847 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20849 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20847 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15767 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20849 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15768 completed with status: 'FAILURE'

@ZhanruiSunCh ZhanruiSunCh force-pushed the user/zhanruis/1008_remove_triton_war_code branch from d960dc9 to eec65fa Compare October 10, 2025 06:18
@ZhanruiSunCh ZhanruiSunCh changed the title [TRTLLM-8464][infra] remove WAR code for triton, simplified installation in CUDA 13 environment [TRTLLM-8464][infra] use script for triton WAR code Oct 10, 2025
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20983 [ run ] triggered by Bot

@ZhanruiSunCh ZhanruiSunCh force-pushed the user/zhanruis/1008_remove_triton_war_code branch from 458183d to eec65fa Compare October 10, 2025 08:07
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20983 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15869 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@ZhanruiSunCh ZhanruiSunCh requested a review from chzblych October 13, 2025 07:17
@ZhanruiSunCh ZhanruiSunCh force-pushed the user/zhanruis/1008_remove_triton_war_code branch from df97c5e to 6b672dc Compare October 14, 2025 02:12
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21281 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21281 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #16067 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Zhanrui Sun <[email protected]>
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21306 [ run ] triggered by Bot

Signed-off-by: Zhanrui Sun <[email protected]>
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21327 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21306 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #16085 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21327 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #16099 (Partly Tested) completed with status: 'FAILURE'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants